Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support groups in a slice's primary section #338

Conversation

angeloashmore
Copy link
Member

@angeloashmore angeloashmore commented Apr 10, 2024

Important

Before merging this PR, update @prismicio/types-internal once https://github.com/prismicio/prismic-types-internal/pull/70 is merged.

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR adds support for group fields in a slice's primary section. This feature will be enabled in Slice Machine and Prismic at a future time.

No breaking changes are introduced in this PR.

Related: DT-2078

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

Sorry, something went wrong.

@angeloashmore angeloashmore marked this pull request as draft April 10, 2024 21:13
@angeloashmore angeloashmore marked this pull request as ready for review April 10, 2024 21:33
Copy link
Member

@lihbr lihbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor suggestion ☺️

angeloashmore and others added 9 commits April 11, 2024 10:49

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…ient-to-fetch-and-type-slice
Copy link
Member

@lihbr lihbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(just leaving that as a checkpoint for me, still looking good, waiting on internal types release)

@angeloashmore angeloashmore merged commit 0672bcb into master May 8, 2024
24 checks passed
@angeloashmore angeloashmore deleted the aa/dt-2078-aadevuser-i-can-use-prismicioclient-to-fetch-and-type-slice branch May 8, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants