-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support extended media API response #326
Conversation
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #326 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 59 59
Lines 6843 6852 +9
Branches 376 376
=======================================
+ Hits 6841 6850 +9
Misses 2 2
☔ View full report in Codecov by Sentry. |
I think we can remove the Following that logic, should we also remove the Otherwise, everything looks good to merge when the API is updated. |
Should be good @angeloashmore, type tests are failing however due to #318, do you want me to finish it? |
@lihbr Awesome! I made a few changes to fix the tests, which uncovered a small bug.
With those fixes, we are good to merge once the updates go live! |
Types of changes
Description
Context: https://prismic-team.slack.com/archives/C014VAACCQL/p1695984909427609
I considered the new properties as optional because users will need to trigger a master ref release for them to appear, but maybe we don't need to? 🤔
This is to be released in sync with API changes in November.
Checklist: