Skip to content

Commit f24feab

Browse files
authoredNov 21, 2024··
fix(popover): update caret styles to offset ::after element (#3204)
Co-authored-by: joshblack <joshblack@users.noreply.github.com>
1 parent a91aa93 commit f24feab

File tree

10 files changed

+9
-0
lines changed

10 files changed

+9
-0
lines changed
 

‎.changeset/strong-donuts-flash.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@primer/view-components': patch
3+
---
4+
5+
Update caret styles for Popover to correctly position caret in different orientations

Error rendering embedded code

Invalid image source.

Error rendering embedded code

Invalid image source.

Error rendering embedded code

Invalid image source.

Error rendering embedded code

Invalid image source.

Error rendering embedded code

Invalid image source.

Error rendering embedded code

Invalid image source.

Error rendering embedded code

Invalid image source.

Error rendering embedded code

Invalid image source.

‎app/components/primer/beta/popover.pcss

+4
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@
9494

9595
&::after {
9696
right: var(--base-size-20);
97+
margin-right: 1px;
9798
}
9899
}
99100

@@ -111,6 +112,7 @@
111112

112113
&::after {
113114
left: var(--base-size-24);
115+
margin-left: 1px;
114116
}
115117
}
116118

@@ -165,6 +167,7 @@
165167

166168
&::after {
167169
left: -14px;
170+
margin-bottom: 1px;
168171
/* stylelint-disable-next-line primer/colors */
169172
border-right-color: var(--overlay-bgColor);
170173
}
@@ -193,6 +196,7 @@
193196

194197
&::after {
195198
bottom: var(--base-size-16);
199+
margin-bottom: 1px;
196200
}
197201
}
198202

0 commit comments

Comments
 (0)
Please sign in to comment.