Skip to content

Commit 683abd2

Browse files
authoredOct 18, 2024··
Delete Primer::Alpha::ImageCrop (#3158)
1 parent 5bc179d commit 683abd2

15 files changed

+5
-284
lines changed
 

‎.changeset/afraid-teachers-battle.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/view-components": minor
3+
---
4+
5+
Delete Primer::Alpha::ImageCrop

‎app/components/primer/alpha/image_crop.html.erb

-12
This file was deleted.

‎app/components/primer/alpha/image_crop.rb

-28
This file was deleted.

‎app/components/primer/alpha/image_crop.ts

-1
This file was deleted.

‎app/components/primer/primer.ts

-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import './focus_group'
99
import './scrollable_region'
1010
import './aria_live'
1111
import './shared_events'
12-
import './alpha/image_crop'
1312
import './alpha/modal_dialog'
1413
import './beta/nav_list'
1514
import './beta/nav_list_group_element'

‎lib/primer/yard/component_manifest.rb

-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ class ComponentManifest
1414
Primer::Alpha::HellipButton => {},
1515
Primer::Alpha::Image => {},
1616
Primer::Alpha::OcticonSymbols => {},
17-
Primer::Alpha::ImageCrop => { js: true },
1817
Primer::IconButton => { js: true },
1918
Primer::Beta::AutoComplete => { js: true },
2019
Primer::Beta::AutoComplete::Item => {},

‎previews/primer/alpha/image_crop_preview.rb

-31
This file was deleted.

‎static/arguments.json

-28
Original file line numberDiff line numberDiff line change
@@ -1351,34 +1351,6 @@
13511351
}
13521352
]
13531353
},
1354-
{
1355-
"component": "ImageCrop",
1356-
"status": "alpha",
1357-
"a11y_reviewed": false,
1358-
"short_name": "ImageCrop",
1359-
"source": "https://github.com/primer/view_components/tree/main/app/components/primer/alpha/image_crop.rb",
1360-
"lookbook": "https://primer.style/view-components/lookbook/inspect/primer/alpha/image_crop/default/",
1361-
"parameters": [
1362-
{
1363-
"name": "src",
1364-
"type": "String",
1365-
"default": "N/A",
1366-
"description": "The path of the image to crop."
1367-
},
1368-
{
1369-
"name": "rounded",
1370-
"type": "Boolean",
1371-
"default": "`true`",
1372-
"description": "If the crop mask should be a circle. Defaults to true."
1373-
},
1374-
{
1375-
"name": "system_arguments",
1376-
"type": "Hash",
1377-
"default": "N/A",
1378-
"description": "[System arguments](/system-arguments)"
1379-
}
1380-
]
1381-
},
13821354
{
13831355
"component": "Layout",
13841356
"status": "alpha",

‎static/audited_at.json

-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
"Primer::Alpha::HellipButton": "",
3131
"Primer::Alpha::HiddenTextExpander": "",
3232
"Primer::Alpha::Image": "",
33-
"Primer::Alpha::ImageCrop": "",
3433
"Primer::Alpha::Layout": "",
3534
"Primer::Alpha::Layout::Main": "",
3635
"Primer::Alpha::Layout::Sidebar": "",

‎static/constants.json

-2
Original file line numberDiff line numberDiff line change
@@ -356,8 +356,6 @@
356356
},
357357
"Primer::Alpha::Image": {
358358
},
359-
"Primer::Alpha::ImageCrop": {
360-
},
361359
"Primer::Alpha::Layout": {
362360
"FIRST_IN_SOURCE_DEFAULT": "sidebar",
363361
"FIRST_IN_SOURCE_OPTIONS": [

‎static/info_arch.json

-95
Original file line numberDiff line numberDiff line change
@@ -4620,101 +4620,6 @@
46204620

46214621
]
46224622
},
4623-
{
4624-
"fully_qualified_name": "Primer::Alpha::ImageCrop",
4625-
"description": "A client-side mechanism to crop images.",
4626-
"accessibility_docs": null,
4627-
"is_form_component": false,
4628-
"is_published": true,
4629-
"requires_js": true,
4630-
"component": "ImageCrop",
4631-
"status": "alpha",
4632-
"a11y_reviewed": false,
4633-
"short_name": "ImageCrop",
4634-
"source": "https://github.com/primer/view_components/tree/main/app/components/primer/alpha/image_crop.rb",
4635-
"lookbook": "https://primer.style/view-components/lookbook/inspect/primer/alpha/image_crop/default/",
4636-
"parameters": [
4637-
{
4638-
"name": "src",
4639-
"type": "String",
4640-
"default": "N/A",
4641-
"description": "The path of the image to crop."
4642-
},
4643-
{
4644-
"name": "rounded",
4645-
"type": "Boolean",
4646-
"default": "`true`",
4647-
"description": "If the crop mask should be a circle. Defaults to true."
4648-
},
4649-
{
4650-
"name": "system_arguments",
4651-
"type": "Hash",
4652-
"default": "N/A",
4653-
"description": "{{link_to_system_arguments_docs}}"
4654-
}
4655-
],
4656-
"slots": [
4657-
{
4658-
"name": "loading",
4659-
"description": "A loading indicator that is shown while the image is loading.",
4660-
"parameters": [
4661-
{
4662-
"name": "system_arguments",
4663-
"type": "Hash",
4664-
"default": "N/A",
4665-
"description": "{{link_to_system_arguments_docs}}"
4666-
}
4667-
]
4668-
}
4669-
],
4670-
"methods": [
4671-
4672-
],
4673-
"previews": [
4674-
{
4675-
"preview_path": "primer/alpha/image_crop/playground",
4676-
"name": "playground",
4677-
"snapshot": "false",
4678-
"skip_rules": {
4679-
"wont_fix": [
4680-
"region"
4681-
],
4682-
"will_fix": [
4683-
"color-contrast"
4684-
]
4685-
}
4686-
},
4687-
{
4688-
"preview_path": "primer/alpha/image_crop/default",
4689-
"name": "default",
4690-
"snapshot": "false",
4691-
"skip_rules": {
4692-
"wont_fix": [
4693-
"region"
4694-
],
4695-
"will_fix": [
4696-
"color-contrast"
4697-
]
4698-
}
4699-
},
4700-
{
4701-
"preview_path": "primer/alpha/image_crop/loading",
4702-
"name": "loading",
4703-
"snapshot": "false",
4704-
"skip_rules": {
4705-
"wont_fix": [
4706-
"region"
4707-
],
4708-
"will_fix": [
4709-
"color-contrast"
4710-
]
4711-
}
4712-
}
4713-
],
4714-
"subcomponents": [
4715-
4716-
]
4717-
},
47184623
{
47194624
"fully_qualified_name": "Primer::Alpha::Layout",
47204625
"description": "`Layout` provides foundational patterns for responsive pages.\n`Layout` can be used for simple two-column pages, or it can be nested to provide flexible 3-column experiences.\n On smaller screens, `Layout` uses vertically stacked rows to display content.\n\n`Layout` flows as both column, when there's enough horizontal space to render both `Main` and `Sidebar`side-by-side (on a desktop of tablet device, per instance);\nor it flows as a row, when `Main` and `Sidebar` are stacked vertically (e.g. on a mobile device).\n`Layout` should always work in any screen size.",

‎static/previews.json

-47
Original file line numberDiff line numberDiff line change
@@ -3978,53 +3978,6 @@
39783978
}
39793979
]
39803980
},
3981-
{
3982-
"name": "image_crop",
3983-
"component": "ImageCrop",
3984-
"status": "alpha",
3985-
"lookup_path": "primer/alpha/image_crop",
3986-
"examples": [
3987-
{
3988-
"preview_path": "primer/alpha/image_crop/playground",
3989-
"name": "playground",
3990-
"snapshot": "false",
3991-
"skip_rules": {
3992-
"wont_fix": [
3993-
"region"
3994-
],
3995-
"will_fix": [
3996-
"color-contrast"
3997-
]
3998-
}
3999-
},
4000-
{
4001-
"preview_path": "primer/alpha/image_crop/default",
4002-
"name": "default",
4003-
"snapshot": "false",
4004-
"skip_rules": {
4005-
"wont_fix": [
4006-
"region"
4007-
],
4008-
"will_fix": [
4009-
"color-contrast"
4010-
]
4011-
}
4012-
},
4013-
{
4014-
"preview_path": "primer/alpha/image_crop/loading",
4015-
"name": "loading",
4016-
"snapshot": "false",
4017-
"skip_rules": {
4018-
"wont_fix": [
4019-
"region"
4020-
],
4021-
"will_fix": [
4022-
"color-contrast"
4023-
]
4024-
}
4025-
}
4026-
]
4027-
},
40283981
{
40293982
"name": "label",
40303983
"component": "Label",

‎static/statuses.json

-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
"Primer::Alpha::HellipButton": "alpha",
3131
"Primer::Alpha::HiddenTextExpander": "alpha",
3232
"Primer::Alpha::Image": "alpha",
33-
"Primer::Alpha::ImageCrop": "alpha",
3433
"Primer::Alpha::Layout": "alpha",
3534
"Primer::Alpha::Layout::Main": "alpha",
3635
"Primer::Alpha::Layout::Sidebar": "alpha",

‎test/components/alpha/image_crop_test.rb

-35
This file was deleted.

‎test/components/component_test.rb

-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ class PrimerComponentTest < Minitest::Test
3333
[Primer::Alpha::TabNav, { label: "label" }],
3434
[Primer::Alpha::UnderlinePanels, { label: "Panel label" }],
3535
[Primer::Alpha::Image, { src: "https://github.com/github.png", alt: "alt" }],
36-
[Primer::Alpha::ImageCrop, { src: "Foo" }],
3736
[Primer::IconButton, { icon: :star, "aria-label": "Label" }],
3837
[Primer::Alpha::ActionList, { aria: { label: "Action List" } }, lambda do |component|
3938
component.with_item(label: "Foo")

0 commit comments

Comments
 (0)
Please sign in to comment.