Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CSS modules feature flag from VisuallyHidden #5785

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Mar 17, 2025

This PR removes the CSS modules feature flag from the VisuallyHidden component. The component VisuallyHidden is used 8 times in dotcom.

Changelog

New

Changed

Removed

Removes the CSS modules feature flag from the SubNav component.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Using Integration testing.

Merge checklist

Sorry, something went wrong.

Copy link

changeset-bot bot commented Mar 17, 2025

🦋 Changeset detected

Latest commit: 8376b65

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 17, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 106.12 KB (+0.06% 🔺)
packages/react/dist/browser.umd.js 106.37 KB (-0.04% 🔽)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/367583

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 17, 2025
@jonrohan jonrohan marked this pull request as ready for review March 17, 2025 22:12
@jonrohan jonrohan requested a review from a team as a code owner March 17, 2025 22:12
@jonrohan jonrohan requested a review from joshblack March 17, 2025 22:12
@jonrohan jonrohan enabled auto-merge March 17, 2025 22:12
@jonrohan jonrohan added this pull request to the merge queue Mar 17, 2025
Merged via the queue into main with commit fbd7fc9 Mar 17, 2025
49 checks passed
@jonrohan jonrohan deleted the css_modules_remove_flag_visuallyhidden branch March 17, 2025 22:25
@primer primer bot mentioned this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants