chore(docs): Add importPath to docs.json #4461
Merged
+91
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a new
next
entry point made the current auto generated component import path in primer.style invalid fornext
components such as tooltip. Discussed this with @camertron and instead of generating the import path based on the component status, we are thinking to make this as a field on the component.docs.json since it is the single source of truth of component artefacts.For now, I only added to the tooltip docs.json files but the intention it to make it required and add it to each docs.json file if I have the consensus. Please let me know if you have any concern with this approach and/or if you have any suggestionsI got some thumbs up so I updated all 🔥
Changelog
New
importPath
to the docs.json - associated primer/design PR Read import path from component json design#752Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist