Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: primer/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: @primer/react@37.12.0
Choose a base ref
...
head repository: primer/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: @primer/react@37.13.0
Choose a head ref
  • 16 commits
  • 108 files changed
  • 11 contributors

Commits on Feb 6, 2025

  1. [Accessibility][Autocomplete] Announce "no selectable options" (#5662)

    * Announce no selectable options
    
    * changeset
    
    * change Announce strategy do debounce
    
    * add missing useEffect dep
    kendallgassner authored Feb 6, 2025

    Unverified

    This user has not yet uploaded their public signing key.
    Copy the full SHA
    613cf0c View commit details
  2. Enable color-contrast Axe check for all stories by default (#5656)

    * test adding color-contrast check
    
    * test
    
    * test
    
    * DevOnly -> Dev
    
    * fix tests
    
    * fix tests
    
    * fix tests
    
    * fix tests
    
    * fix tests
    
    * fix tests
    
    * Update e2e/matchers/toHaveNoViolations.ts
    
    * inline
    kendallgassner authored Feb 6, 2025
    Copy the full SHA
    6381219 View commit details

Commits on Feb 7, 2025

  1. ActionList: Allow items to remain focusable when disabled (#4481)

    * Allow `ActionMenu` items, or `SelectPanel` items to be focusable when `disabled`
    
    * Add changeset
    
    * Update PR based on feedback
    
    * Fix for test
    
    ---------
    
    Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
    TylerJDev and siddharthkp authored Feb 7, 2025
    Copy the full SHA
    6e7da1e View commit details
  2. fix(Dialog): stress test story to go fullscreen on narrow screens (#5628

    )
    hectahertz authored Feb 7, 2025
    Copy the full SHA
    621c878 View commit details
  3. Update motion tokens (#5667)

    * Update motion tokens
    
    * Update SkeletonBox.module.css
    
    * add cahngeset
    lukasoppermann authored Feb 7, 2025
    Copy the full SHA
    10436f5 View commit details
  4. Remove 100+ tests duplicated by axe.test.ts when color-contrast rule …

    …is enabled (#5659)
    
    * test adding color-contrast check
    
    * test
    
    * test
    
    * DevOnly -> Dev
    
    * fix tests
    
    * fix tests
    
    * fix tests
    
    * fix tests
    
    * fix tests
    
    * fix tests
    
    * Update e2e/matchers/toHaveNoViolations.ts
    
    * Remove tests duplicated by axe.test.ts
    
    * inline
    kendallgassner authored Feb 7, 2025
    Copy the full SHA
    f917b33 View commit details
  5. chore(FormControl): Move FormControl css modules feature flag from te…

    …am to staff (#5669)
    
    * Move FormControl feature flag to staff
    
    * Create lucky-camels-compete.md
    jonrohan authored Feb 7, 2025
    Copy the full SHA
    b2bc006 View commit details
  6. chore: Remove unused primer_react_css_modules_team feature flag (#5670)

    * Move FormControl feature flag to staff
    
    * Remove unused primer_react_css_modules_team feature flag
    jonrohan authored Feb 7, 2025
    Copy the full SHA
    7ee5e2e View commit details

Commits on Feb 8, 2025

  1. Overlay: only prevent focus on open when component is open (#5636)

    * only prevent focus when component is open
    
    Otherwise, prevents focus from returning to given returnFocusRef.
    
    * fixup callback
    
    * add component tests asserting expected behavior
    
    * update hook tests
    
    * add changeset
    
    * add dev story for preventFocusOnOpen
    
    * document preventFocusOnOpen prop
    
    Based on hooks docs:
    * https://primer.style/guides/react/hooks/use-open-and-close-focus
    
    Related:
    * primer/design#926
    ktravers authored Feb 8, 2025
    Copy the full SHA
    c2165af View commit details

Commits on Feb 10, 2025

  1. chore(deps): bump postcss-preset-env from 10.0.0 to 10.1.3 (#5676)

    Bumps [postcss-preset-env](https://github.com/csstools/postcss-plugins/tree/HEAD/plugin-packs/postcss-preset-env) from 10.0.0 to 10.1.3.
    - [Changelog](https://github.com/csstools/postcss-plugins/blob/main/plugin-packs/postcss-preset-env/CHANGELOG.md)
    - [Commits](https://github.com/csstools/postcss-plugins/commits/HEAD/plugin-packs/postcss-preset-env)
    
    ---
    updated-dependencies:
    - dependency-name: postcss-preset-env
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Feb 10, 2025
    Copy the full SHA
    9320b6b View commit details
  2. chore(deps-dev): bump @babel/preset-react from 7.24.7 to 7.26.3 (#5674)

    Bumps [@babel/preset-react](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-react) from 7.24.7 to 7.26.3.
    - [Release notes](https://github.com/babel/babel/releases)
    - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/babel/babel/commits/v7.26.3/packages/babel-preset-react)
    
    ---
    updated-dependencies:
    - dependency-name: "@babel/preset-react"
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Feb 10, 2025
    Copy the full SHA
    8901f91 View commit details
  3. chore(deps-dev): bump eslint-import-resolver-typescript (#5675)

    Bumps [eslint-import-resolver-typescript](https://github.com/import-js/eslint-import-resolver-typescript) from 3.6.1 to 3.7.0.
    - [Release notes](https://github.com/import-js/eslint-import-resolver-typescript/releases)
    - [Changelog](https://github.com/import-js/eslint-import-resolver-typescript/blob/master/CHANGELOG.md)
    - [Commits](import-js/eslint-import-resolver-typescript@v3.6.1...v3.7.0)
    
    ---
    updated-dependencies:
    - dependency-name: eslint-import-resolver-typescript
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Feb 10, 2025
    Copy the full SHA
    add0cac View commit details
  4. chore(deps-dev): bump eslint-plugin-prettier from 5.0.0 to 5.2.3 (#5678)

    Bumps [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) from 5.0.0 to 5.2.3.
    - [Release notes](https://github.com/prettier/eslint-plugin-prettier/releases)
    - [Changelog](https://github.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md)
    - [Commits](prettier/eslint-plugin-prettier@v5.0.0...v5.2.3)
    
    ---
    updated-dependencies:
    - dependency-name: eslint-plugin-prettier
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Feb 10, 2025
    Copy the full SHA
    51c28f6 View commit details
  5. Remove the CSS modules feature flag from the Hidden component (#5683)

    * Remove the CSS modules feature flag from the Hidden component
    
    * Create violet-ladybugs-melt.md
    
    * Remove unused imports
    jonrohan authored Feb 10, 2025
    Copy the full SHA
    8bb78e1 View commit details

Commits on Feb 11, 2025

  1. feat: Introduce Tooltip to SegmentedControlIconButton (#5679)

    * feat: Introduce Tooltip to SegmentedControlIconButton
    
    * fix: Ensure tooltip renders description
    
    * Create sharp-flowers-repair.md
    
    * fix: run prettier
    
    * test to fill out
    
    * all tests pass
    
    * update docs
    
    * Run prettier
    
    * Swap to use feature flag
    
    * Fix syntax issue
    
    * Remove unsafeDisableTooltip from branch
    khiga8 authored Feb 11, 2025
    Copy the full SHA
    dbcb8f7 View commit details

Commits on Feb 13, 2025

  1. Version Packages (#5665)

    Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
    primer[bot] and github-actions[bot] authored Feb 13, 2025
    Copy the full SHA
    28fc651 View commit details
Showing with 1,454 additions and 2,997 deletions.
  1. +0 −1 .github/workflows/aat-reports.yml
  2. +0 −1 .github/workflows/vrt-reports.yml
  3. +0 −64 e2e/components/Avatar.test.ts
  4. +0 −48 e2e/components/AvatarPair.test.ts
  5. +0 −16 e2e/components/Breadcrumbs.test.ts
  6. +3 −262 e2e/components/Button.test.ts
  7. +2 −2 e2e/components/ButtonGroup.test.ts
  8. +0 −80 e2e/components/Flash.test.ts
  9. +0 −16 e2e/components/Header.test.ts
  10. +1 −172 e2e/components/IconButton.test.ts
  11. +0 −208 e2e/components/Label.test.ts
  12. +1 −1 e2e/components/Link.test.ts
  13. +0 −176 e2e/components/LinkButton.test.ts
  14. +1 −1 e2e/components/NavList.test.ts
  15. +1 −230 e2e/components/PageHeader.test.ts
  16. +0 −48 e2e/components/Radio.test.ts
  17. +0 −16 e2e/components/Select.test.ts
  18. +7 −1 e2e/components/SelectPanel.test.ts
  19. +0 −320 e2e/components/Skeletons.test.ts
  20. +0 −16 e2e/components/SubNav.test.ts
  21. +0 −16 e2e/components/TextInputWithTokens.test.ts
  22. +0 −16 e2e/components/Textarea.test.ts
  23. +0 −32 e2e/components/Timeline.test.ts
  24. +0 −133 e2e/components/ToggleSwitch.test.ts
  25. +0 −80 e2e/components/TreeView.test.ts
  26. +0 −128 e2e/components/UnderlineNav.test.ts
  27. +0 −16 e2e/components/UnderlinePanels.test.ts
  28. +38 −5 e2e/matchers/toHaveNoViolations.ts
  29. +1 −1 examples/codesandbox/package.json
  30. +1 −1 examples/nextjs/package.json
  31. +1 −1 examples/theming/package.json
  32. +813 −694 package-lock.json
  33. +3 −2 package.json
  34. +1 −1 packages/postcss-preset-primer/package.json
  35. +4 −8 packages/react/.storybook/preview.jsx
  36. +22 −0 packages/react/CHANGELOG.md
  37. +2 −2 packages/react/package.json
  38. +0 −2 packages/react/src/ActionList/ActionList.test.tsx
  39. +0 −1 packages/react/src/ActionList/Description.test.tsx
  40. +0 −1 packages/react/src/ActionList/Group.test.tsx
  41. +0 −1 packages/react/src/ActionList/Heading.test.tsx
  42. +0 −5 packages/react/src/ActionList/Item.test.tsx
  43. +8 −1 packages/react/src/ActionList/Item.tsx
  44. +0 −3 packages/react/src/ActionMenu/ActionMenu.dev.stories.tsx
  45. +56 −0 packages/react/src/ActionMenu/ActionMenu.features.stories.tsx
  46. +1 −1 packages/react/src/AnchoredOverlay/AnchoredOverlay.features.stories.tsx
  47. +16 −0 packages/react/src/Autocomplete/AutocompleteMenu.tsx
  48. +0 −1 packages/react/src/Banner/Banner.test.tsx
  49. +0 −1 packages/react/src/BranchName/__tests__/BranchName.test.tsx
  50. +0 −1 packages/react/src/Breadcrumbs/__tests__/Breadcrumbs.test.tsx
  51. +1 −1 packages/react/src/Button/Button.dev.stories.tsx
  52. +1 −1 packages/react/src/Button/IconButton.dev.stories.tsx
  53. +0 −3 packages/react/src/Button/__tests__/Button.test.tsx
  54. +1 −1 packages/react/src/ButtonGroup/ButtonGroup.dev.stories.tsx
  55. +0 −1 packages/react/src/ButtonGroup/ButtonGroup.test.tsx
  56. +0 −1 packages/react/src/Checkbox/Checkbox.test.tsx
  57. +0 −1 packages/react/src/CounterLabel/CounterLabel.test.tsx
  58. +0 −3 packages/react/src/Dialog/Dialog.dev.stories.tsx
  59. +1 −0 packages/react/src/Dialog/Dialog.features.stories.tsx
  60. +0 −1 packages/react/src/Dialog/Dialog.test.tsx
  61. +0 −1 packages/react/src/DialogV1/Dialog.test.tsx
  62. +1 −1 packages/react/src/FeatureFlags/DefaultFeatureFlags.ts
  63. +1 −1 packages/react/src/FormControl/feature-flags.ts
  64. +0 −2 packages/react/src/Header/Header.dev.stories.tsx
  65. +0 −1 packages/react/src/Heading/__tests__/Heading.test.tsx
  66. +20 −27 packages/react/src/Hidden/Hidden.test.tsx
  67. +2 −13 packages/react/src/Hidden/Hidden.tsx
  68. +2 −7 packages/react/src/Hidden/__snapshots__/Hidden.test.tsx.snap
  69. +1 −1 packages/react/src/Link/Link.dev.stories.tsx
  70. +0 −1 packages/react/src/Link/__tests__/Link.test.tsx
  71. +1 −1 packages/react/src/NavList/NavList.dev.stories.tsx
  72. +142 −0 packages/react/src/Overlay/Overlay.dev.stories.tsx
  73. +64 −9 packages/react/src/Overlay/Overlay.test.tsx
  74. +1 −0 packages/react/src/Overlay/Overlay.tsx
  75. +1 −1 packages/react/src/PageHeader/PageHeader.dev.stories.tsx
  76. +4 −1 packages/react/src/PageLayout/PageLayout.features.stories.tsx
  77. +14 −2 packages/react/src/SegmentedControl/SegmentedControl.docs.json
  78. +84 −3 packages/react/src/SegmentedControl/SegmentedControl.test.tsx
  79. +59 −27 packages/react/src/SegmentedControl/SegmentedControlIconButton.tsx
  80. +0 −3 packages/react/src/SelectPanel/SelectPanel.dev.stories.tsx
  81. +1 −1 packages/react/src/Spinner/Spinner.module.css
  82. +0 −1 packages/react/src/Stack/__tests__/Stack.test.tsx
  83. +0 −1 packages/react/src/Stack/__tests__/StackItem.test.tsx
  84. +0 −2 packages/react/src/SubNav/SubNav.dev.stories.tsx
  85. +0 −2 packages/react/src/TextInput/TextInput.dev.stories.tsx
  86. +0 −5 packages/react/src/Timeline/__tests__/Timeline.test.tsx
  87. +0 −1 packages/react/src/TreeView/TreeView.test.tsx
  88. +0 −2 packages/react/src/__tests__/Autocomplete.test.tsx
  89. +0 −1 packages/react/src/__tests__/Avatar.test.tsx
  90. +0 −1 packages/react/src/__tests__/AvatarStack.test.tsx
  91. +0 −1 packages/react/src/__tests__/Box.test.tsx
  92. +0 −3 packages/react/src/__tests__/Header.test.tsx
  93. +0 −1 packages/react/src/__tests__/Label.test.tsx
  94. +0 −1 packages/react/src/__tests__/Popover.test.tsx
  95. +0 −1 packages/react/src/__tests__/ProgressBar.test.tsx
  96. +0 −1 packages/react/src/__tests__/Radio.test.tsx
  97. +0 −1 packages/react/src/__tests__/Select.test.tsx
  98. +0 −1 packages/react/src/__tests__/SubNav.test.tsx
  99. +0 −1 packages/react/src/__tests__/TextInput.test.tsx
  100. +0 −1 packages/react/src/__tests__/TextInputWithTokens.test.tsx
  101. +0 −1 packages/react/src/__tests__/Textarea.test.tsx
  102. +47 −3 packages/react/src/__tests__/hooks/useOpenAndCloseFocus.test.tsx
  103. +1 −1 packages/react/src/experimental/Skeleton/SkeletonBox.module.css
  104. +0 −1 packages/react/src/experimental/Skeleton/__tests__/SkeletonBox.test.tsx
  105. +0 −1 packages/react/src/experimental/Skeleton/__tests__/SkeletonText.test.tsx
  106. +13 −10 packages/react/src/hooks/useOpenAndCloseFocus.ts
  107. +6 −1 packages/react/src/stories/useFocusZone.stories.tsx
  108. +2 −2 script/generate-e2e-tests.js
1 change: 0 additions & 1 deletion .github/workflows/aat-reports.yml
Original file line number Diff line number Diff line change
@@ -91,7 +91,6 @@ jobs:
matrix:
shard: [1, 2, 3, 4]
env:
VITE_PRIMER_REACT_CSS_MODULES_TEAM: 1
VITE_PRIMER_REACT_CSS_MODULES_STAFF: 1
VITE_PRIMER_REACT_CSS_MODULES_GA: 1
steps:
1 change: 0 additions & 1 deletion .github/workflows/vrt-reports.yml
Original file line number Diff line number Diff line change
@@ -91,7 +91,6 @@ jobs:
matrix:
shard: [1, 2, 3, 4]
env:
VITE_PRIMER_REACT_CSS_MODULES_TEAM: 1
VITE_PRIMER_REACT_CSS_MODULES_STAFF: 1
VITE_PRIMER_REACT_CSS_MODULES_GA: 1
steps:
64 changes: 0 additions & 64 deletions e2e/components/Avatar.test.ts
Original file line number Diff line number Diff line change
@@ -17,22 +17,6 @@ test.describe('Avatar', () => {
// Default state
expect(await page.screenshot()).toMatchSnapshot(`Avatar.Default.${theme}.png`)
})

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'components-avatar--default',
globals: {
colorScheme: theme,
},
})
await expect(page).toHaveNoViolations({
rules: {
'color-contrast': {
enabled: theme !== 'dark_dimmed',
},
},
})
})
})
}
})
@@ -51,22 +35,6 @@ test.describe('Avatar', () => {
// Default state
expect(await page.screenshot()).toMatchSnapshot(`Avatar.Size.${theme}.png`)
})

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'components-avatar-features--size',
globals: {
colorScheme: theme,
},
})
await expect(page).toHaveNoViolations({
rules: {
'color-contrast': {
enabled: theme !== 'dark_dimmed',
},
},
})
})
})
}
})
@@ -85,22 +53,6 @@ test.describe('Avatar', () => {
// Default state
expect(await page.screenshot()).toMatchSnapshot(`Avatar.Size Responsive.${theme}.png`)
})

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'components-avatar-features--size-responsive',
globals: {
colorScheme: theme,
},
})
await expect(page).toHaveNoViolations({
rules: {
'color-contrast': {
enabled: theme !== 'dark_dimmed',
},
},
})
})
})
}
})
@@ -119,22 +71,6 @@ test.describe('Avatar', () => {
// Default state
expect(await page.screenshot()).toMatchSnapshot(`Avatar.Square.${theme}.png`)
})

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'components-avatar-features--square',
globals: {
colorScheme: theme,
},
})
await expect(page).toHaveNoViolations({
rules: {
'color-contrast': {
enabled: theme !== 'dark_dimmed',
},
},
})
})
})
}
})
48 changes: 0 additions & 48 deletions e2e/components/AvatarPair.test.ts
Original file line number Diff line number Diff line change
@@ -17,22 +17,6 @@ test.describe('AvatarPair', () => {
// Default state
expect(await page.screenshot()).toMatchSnapshot(`AvatarPair.Default.${theme}.png`)
})

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'components-avatarpair--default',
globals: {
colorScheme: theme,
},
})
await expect(page).toHaveNoViolations({
rules: {
'color-contrast': {
enabled: theme !== 'dark_dimmed',
},
},
})
})
})
}
})
@@ -51,22 +35,6 @@ test.describe('AvatarPair', () => {
// Default state
expect(await page.screenshot()).toMatchSnapshot(`AvatarPair.Parent Circle.${theme}.png`)
})

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'components-avatarpair-features--parent-circle',
globals: {
colorScheme: theme,
},
})
await expect(page).toHaveNoViolations({
rules: {
'color-contrast': {
enabled: theme !== 'dark_dimmed',
},
},
})
})
})
}
})
@@ -85,22 +53,6 @@ test.describe('AvatarPair', () => {
// Default state
expect(await page.screenshot()).toMatchSnapshot(`AvatarPair.Parent Square.${theme}.png`)
})

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'components-avatarpair-features--parent-square',
globals: {
colorScheme: theme,
},
})
await expect(page).toHaveNoViolations({
rules: {
'color-contrast': {
enabled: theme !== 'dark_dimmed',
},
},
})
})
})
}
})
16 changes: 0 additions & 16 deletions e2e/components/Breadcrumbs.test.ts
Original file line number Diff line number Diff line change
@@ -25,22 +25,6 @@ test.describe('Breadcrumbs', () => {
await page.keyboard.press('Tab')
expect(await page.screenshot()).toMatchSnapshot(`Breadcrumbs.Default.${theme}.focus.png`)
})

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'components-breadcrumbs--default',
globals: {
colorScheme: theme,
},
})
await expect(page).toHaveNoViolations({
rules: {
'color-contrast': {
enabled: theme !== 'dark_dimmed',
},
},
})
})
})
}
})
Loading