Adding data gradient #1193
Merged
Adding data gradient #1193
+989
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 781d015 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Design Token Diff (CSS)The message is too long to be displayed here. For more details, please check the job summary. |
Design Token Diff (StyleLint)The message is too long to be displayed here. For more details, please check the job summary. |
Design Token Diff (Figma)The message is too long to be displayed here. For more details, please check the job summary. |
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
added
the
update snapshots
github-actions
bot
removed
the
update snapshots
langermank
reviewed
Mar 11, 2025
| }, | ||
| }, | ||
| }, | ||
| 'gradient-stop-1': { |
There was a problem hiding this comment.
Is there a reason this is the full string instead of nested values for the token name?
There was a problem hiding this comment.
Good point, I adjusted it to gradientStop and nested 1 and 2 inside.
lukasoppermann
force-pushed
the
data-gradients
branch
from
efe99c8 to
e8eab83
Compare
lukasoppermann
added
the
update snapshots
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
removed
the
update snapshots
lukasoppermann
added
the
update snapshots
github-actions
bot
removed
the
update snapshots
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
added
update snapshots
github-actions
bot
removed
the
update snapshots
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds gradients for data visualization using the muted color.
I am adding special colors
gradientStop-1andgradientStop-2as well as an assembled gradient. This is important because both in svg gradients and in Figma we need the individual colors rather than a combined gradient like in css.