Add new Feed icons #977
Merged
Add new Feed icons #977
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed-16.svg, feed-issue-open-16.svg, feed-add-user-16.svg, feed-public-16.svg, feed-pull-request-closed-16.svg, feed-pull-request-draft-16.svg, feed-pull-request-open-16.svg
🦋 Changeset detectedLatest commit: e2024d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tallys
approved these changes
Aug 17, 2023
Merged
|
When adding this new icons to our library of Octicons in Figma (to keep it updated), I've noticed that two of the issue icons are called the same "feed-issue-open" resulting with the package only containing the icon that looks like reopen. What is the normal procedure in this cases? Should I open a separate issue for this? |
|
@marcalcobe thank you for reporting this! I should have a fix ready to go in #980 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/2529
Adds a handful of new Feed icons