Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round brackets pattern not working #125

Closed
Tom4U opened this issue Feb 25, 2021 · 2 comments · Fixed by #184
Closed

Round brackets pattern not working #125

Tom4U opened this issue Feb 25, 2021 · 2 comments · Fixed by #184

Comments

@Tom4U
Copy link

Tom4U commented Feb 25, 2021

It seems the round brackets pattern doesn't work as expected.

This doesn't work:
pretty-quick --staged --pattern "**/(apps|libs|tools)/**/*"

This does:
pretty-quick --staged --pattern "**/apps/**/*" --pattern "**/libs/**/*" --pattern "**/tools/**/*"

It seems that somehow round brackets aren't supported in this scenario.
@jimyhdolores
Copy link

Hello, were you able to solve this problem?

@JounQin
Copy link
Member

JounQin commented Jan 16, 2024

A minimal but runnable online reproduction is required.

SukkaW added a commit to SukkaW/pretty-quick that referenced this issue Jan 17, 2024
@SukkaW
test(prettier#73/prettier#125): add glob regex group
157775c
@SukkaW SukkaW mentioned this issue Jan 17, 2024
Merged
JounQin added a commit that referenced this issue Jan 17, 2024
@SukkaW @JounQin
test(#73/#125): add glob regex group cases (#184)
1536657 
Co-authored-by: JounQin <admin@1stg.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(#73/#125): add glob regex group cases SukkaW/pretty-quick
3 participants
@JounQin @jimyhdolores @Tom4U