Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong formatting on flow shorthand annotation comment with other comments #7510

Closed
fisker opened this issue Feb 1, 2020 · 1 comment
Closed

Wrong formatting on flow shorthand annotation comment with other comments #7510

fisker opened this issue Feb 1, 2020 · 1 comment
Labels
area:flow comment types lang:flow Issues affecting Flow-specific constructs (not general JS issues) type:bug Issues identifying ugly output, or a defect in the program

Comments

@fisker
Copy link
Member

fisker commented Feb 1, 2020 •
edited

Prettier 1.19.1
Playground link

--parser flow

Input:

(0 /* comment */ /*: number */)

Output:

(0 /*: /* comment */ number */);

Second Output:

SyntaxError: Unexpected token `*/`. Did you mean `*-/`? (1:19)
> 1 | (0 /*: /* comment */ number */);
    |                   ^^
  2 |

Flow's playground
@fisker fisker mentioned this issue Feb 1, 2020
Closed
@thorn0 thorn0 added lang:flow Issues affecting Flow-specific constructs (not general JS issues) type:bug Issues identifying ugly output, or a defect in the program labels Feb 1, 2020
@thorn0 thorn0 mentioned this issue Oct 21, 2022
Merged
5 tasks
@thorn0
Copy link
Member

thorn0 commented Oct 24, 2022

Fixed by #13687

@thorn0 thorn0 closed this as completed Oct 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area:flow comment types lang:flow Issues affecting Flow-specific constructs (not general JS issues) type:bug Issues identifying ugly output, or a defect in the program
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thorn0 @fisker