Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier crashes on some Flow comment types #6288

Closed
mrm007 opened this issue Jul 11, 2019 · 2 comments
Closed

Prettier crashes on some Flow comment types #6288

mrm007 opened this issue Jul 11, 2019 · 2 comments
Assignees
Labels
area:comments Issues with how Prettier prints comments area:flow comment types type:bug Issues identifying ugly output, or a defect in the program

Comments

@mrm007
Copy link

mrm007 commented Jul 11, 2019

Prettier 1.18.2
Playground link

--parser babylon

Input:

React.forwardRef/*::<Props,any>*/((props, ref) => <Link innerRef={ref} {...props} />);

Output:

ensureAllCommentsPrinted/<@https://prettier.io/lib/standalone.js:16187:13
ensureAllCommentsPrinted@https://prettier.io/lib/standalone.js:16185:15
coreFormat@https://prettier.io/lib/standalone.js:16236:3
format@https://prettier.io/lib/standalone.js:16476:73
formatWithCursor@https://prettier.io/lib/standalone.js:16492:12
withPlugins/<@https://prettier.io/lib/standalone.js:30992:15
format@https://prettier.io/lib/standalone.js:31000:12
formatCode@https://prettier.io/worker.js:234:21
handleMessage@https://prettier.io/worker.js:185:18
self.onmessage@https://prettier.io/worker.js:155:14

Expected behavior:
Prettier should not crash.

@duailibe duailibe added area:comments Issues with how Prettier prints comments type:bug Issues identifying ugly output, or a defect in the program labels Jul 11, 2019
@duailibe duailibe self-assigned this Jul 11, 2019
@gautamsi
Copy link

ref: #4295

@thorn0
Copy link
Member

thorn0 commented Oct 24, 2022

Not an issue anymore because support for Flow comments was removed in #13687

@thorn0 thorn0 closed this as completed Oct 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:comments Issues with how Prettier prints comments area:flow comment types type:bug Issues identifying ugly output, or a defect in the program
Projects
None yet
Development

No branches or pull requests

5 participants