Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install script for husky v9 #16000

Merged
merged 4 commits into from Feb 3, 2024
Merged

Update install script for husky v9 #16000

merged 4 commits into from Feb 3, 2024

Conversation

ohaddahan
Copy link
Contributor

Description

Changes according to https://github.com/typicode/husky/releases/tag/v9.0.1

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

docs/install.md Outdated Show resolved Hide resolved
Co-authored-by: fisker Cheung <lionkay@gmail.com>
docs/install.md Outdated Show resolved Hide resolved
@fisker
Copy link
Member

fisker commented Feb 3, 2024

Would you like to remind husky to update their recommended scripts?

@ohaddahan
Copy link
Contributor Author

Would you like to remind husky to update their recommended scripts?

Which part? The windows compatibility?

@fisker
Copy link
Member

fisker commented Feb 3, 2024

The windows compatibility?

Yes.

@ohaddahan
Copy link
Contributor Author

The windows compatibility?

Yes.

Pretty sure their assumption is git bash is used, they specifically mention On windows.

@fisker
Copy link
Member

fisker commented Feb 3, 2024

typicode/husky#1380

@fisker fisker changed the title update husky v9 Update install script for husky v9 Feb 3, 2024
@fisker fisker merged commit 08f1940 into prettier:main Feb 3, 2024
28 checks passed
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 18, 2024
Co-authored-by: fisker Cheung <lionkay@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants