Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve keyword detection in TSModuleDeclaration #15925

Merged
merged 1 commit into from Jan 16, 2024

Conversation

fisker
Copy link
Member

@fisker fisker commented Jan 15, 2024

Description

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@@ -113,6 +117,10 @@ namespace X {
}
}

namespace /* module */ X {}
module /* namespace */ X {}
module /* namespace */ "x" {}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only happens with parser: 'babel-ts', not going to add changelog for it.

Prettier 3.2.2
Playground link

--parser babel-ts

Input:

namespace /* module */ X {}
module /* namespace */ X {}

Output:

module /* module */ X {}
module /* namespace */ X {}

@fisker fisker marked this pull request as ready for review January 15, 2024 11:39
@fisker fisker merged commit 10762ee into prettier:main Jan 16, 2024
25 of 26 checks passed
@fisker fisker deleted the TSModuleDeclaration branch January 16, 2024 02:28
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants