New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make chalk/assert shim a Proxy #15234

Merged

fisker merged 2 commits into prettier:main from fisker:chalk

Aug 15, 2023

Member

fisker commented Aug 11, 2023

Description

Checklist

I’ve added tests to confirm my change works.
(If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
(If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
I’ve read the contributing guidelines.

✨Try the playground for this PR✨

fisker added 2 commits

August 11, 2023 18:53


          Make chalk shim a Proxy

f70d230


          assert

1fb1651

fisker force-pushed the chalk branch from 1d40d17 to 1fb1651 Compare

August 11, 2023 10:54

sosukesuzuki reviewed

View reviewed changes

Member

sosukesuzuki left a comment

Why? Just refactoring?

Member Author

fisker commented Aug 14, 2023

Refactor, but safer, in case we use unlisted color from chalk.

Member Author

fisker commented Aug 15, 2023

@babel/highlight@7.22.10 need this change, it uses chalk.white.bgRed.bold https://unpkg.com/browse/@babel/highlight@7.22.10/lib/index.js

fisker merged commit f24132e into prettier:main

29 checks passed

fisker deleted the chalk branch

August 15, 2023 01:11

medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request


          Make chalk/assert shim a Proxy (prettier#15234)

b4a9a60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment