Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flat config for the project's eslint configuration #615

Merged
merged 2 commits into from Dec 3, 2023

Conversation

BPScott
Copy link
Member

@BPScott BPScott commented Dec 3, 2023

Convert the project's eslint config to the flat style.

This shall let us dogfood the recommended eslint config when we add it.

This is a 1:1 migration, with the exception of adding .github/ISSUE_TEMPLATE.md to the ignores. I'm not sure what I've managed to do here, but it seems we weren't linting that before but now we are.

Copy link

changeset-bot bot commented Dec 3, 2023

⚠️ No Changeset found

Latest commit: 88bb87e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JounQin
Copy link
Member

JounQin commented Dec 3, 2023

package.json Show resolved Hide resolved
Copy link
Member

@JounQin JounQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add mdx plugin back.

@BPScott
Copy link
Member Author

BPScott commented Dec 3, 2023

Gotcha, I hadn't clocked that eslint-plugin-mdx also lints against the markdowny portions of the markdown file rather than just the codeblocks. I'll add it back.

@BPScott BPScott requested a review from JounQin December 3, 2023 05:24
@BPScott
Copy link
Member Author

BPScott commented Dec 3, 2023

There we go, I believe that's the markdown stuff put back properly. That last rebase was tidying up the wording of the global ignores block at the bottom and some variable renaming. @JounQin I've tagged you for one last re-review if you'd be so kind.

@BPScott BPScott merged commit 78c8b80 into master Dec 3, 2023
4 checks passed
@BPScott BPScott deleted the localflatconfig branch December 3, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants