feat: add duckdb dialect #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damian Peckett <damian@pecke.tt>
dpeckett
force-pushed
the
add-duckdb-dialect
branch
from
7409481
to
b9505db
Compare
|
Thanks for contributing a PR, will review this over the next week or two. |
mfridman
reviewed
Feb 12, 2024
|
|
||
| func (s *Duckdb) CreateTable(tableName string) string { | ||
| q := ` | ||
| CREATE SEQUENCE %s_id; |
There was a problem hiding this comment.
I don't have much experience with duckdb, is this the recommended way to get an autoincrementing primary key?
There was a problem hiding this comment.
At this time I'm hardly an expert but that seemed to be the main way to achieve this. You certainly don't have an AUTOINCREMENT keyword on the column available.
mfridman
approved these changes
Feb 12, 2024
mfridman
approved these changes
Feb 15, 2024
|
Thanks for putting up a PR 🎉 . |
mfridman
added a commit
that referenced
this pull request
Mar 13, 2024
This reverts commit fb7ca2d. # Conflicts: # cmd/goose/driver_duckdb.go
mfridman
added a commit
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at adding DuckDB dialect support.