Builds produced for electron 11 are broken

[Julusian]

This is a snippet of a discovery found in serialport/node-serialport#2191 (comment)

I have raised an issue (electron/node-abi#103) with node-abi to investigate a fix, but I don't know if they will be willing to do anything

When building for electron 11, prebuild is using the headers for v11.0.0-beta.11. However due to some changes introduced in v11.0.0-beta.12, these binaries can be incompatible with other versions of electron 11.
I have confirmed this in that library by trying to run builds produced directly from node-gyp using both v11.0.0-beta.11 and v11.0.0-beta.12 headers in various versions of electron 11. I also manually applied this patch onto my cached v11.0.0-beta.11 headers to confirm it is the snippet at fault.

The fix is simply to use a different version of the headers than node-abi says. Hopefully this is a one-off and wont be a recurring issue in future electron versions

[lovell]

@Julusian Is this still an issue, or can this now be closed?

[Julusian]

I have no idea. I now avoid any non node-api native library, to avoid issues such as this.

[lovell]

@Julusian Thank you, it looks like serialport migrated to Node-API in late 2021 / early 2022 as part of serialport/node-serialport#2305 so I'll close.