Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Skip benches during release workflows #4686

Merged
merged 2 commits into from
Feb 18, 2025
Merged

ci: Skip benches during release workflows #4686

merged 2 commits into from
Feb 18, 2025
+8 −2

Conversation

rschristian
Copy link
Member

@rschristian rschristian commented Feb 18, 2025 •
edited
Loading

Our filter pattern is a bit broad, it picks up changes to devtools/src/devtools.js which gets altered on every release: #4684 (comment)

Should be fine to exclude it specifically, none of our benchmarks depend on it anyhow.

Edit: The PR Reporter action is expected to run on this PR as the running version is that on main, not this PR. The benches, however, should be skipped as a result. Workflow showing this.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +0% (-9.03ms - +1.94ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -2% - +0% (-0.32ms - +0.06ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -0% - +1% (-0.22ms - +1.17ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -2% - +1% (-0.37ms - +0.18ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.86ms - +0.98ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -4% - +4% (-0.09ms - +0.09ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +0% (-0.22ms - +0.11ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -2% - +5% (-0.66ms - +1.56ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.01ms - +0.03ms)
    preact-local vs preact-main
  • filter-list: faster ✔ 1% - 4% (0.01ms - 0.07ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +5% (-0.09ms - +0.48ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.02ms - +0.02ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -2% - +1% (-0.03ms - +0.02ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -1% - +1% (-0.02ms - +0.02ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local939.92ms - 945.45ms-unsure 🔍
-1% - +0%
-9.03ms - +1.94ms
preact-main941.49ms - 950.97msunsure 🔍
-0% - +1%
-1.94ms - +9.03ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.18ms - 19.21ms-unsure 🔍
-0% - +0%
-0.01ms - +0.03ms
preact-main19.18ms - 19.20msunsure 🔍
-0% - +0%
-0.03ms - +0.01ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.58ms - 16.63ms-unsure 🔍
-2% - +0%
-0.32ms - +0.06ms
preact-main16.54ms - 16.92msunsure 🔍
-0% - +2%
-0.06ms - +0.32ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.53ms - 1.55ms-faster ✔
1% - 4%
0.01ms - 0.07ms
preact-main1.56ms - 1.60msslower ❌
1% - 4%
0.01ms - 0.07ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local78.03ms - 78.98ms-unsure 🔍
-0% - +1%
-0.22ms - +1.17ms
preact-main77.53ms - 78.53msunsure 🔍
-1% - +0%
-1.17ms - +0.22ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local10.60ms - 11.01ms-unsure 🔍
-1% - +5%
-0.09ms - +0.48ms
preact-main10.41ms - 10.81msunsure 🔍
-4% - +1%
-0.48ms - +0.09ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.03ms - 16.45ms-unsure 🔍
-2% - +1%
-0.37ms - +0.18ms
preact-main16.16ms - 16.51msunsure 🔍
-1% - +2%
-0.18ms - +0.37ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.76ms - 3.77ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main3.76ms - 3.78msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4443

  • Commit: 3ddb9a4

duration

VersionAvg timevs preact-localvs preact-main
preact-local67.25ms - 68.34ms-unsure 🔍
-1% - +1%
-0.86ms - +0.98ms
preact-main66.99ms - 68.47msunsure 🔍
-1% - +1%
-0.98ms - +0.86ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.97ms - 3.00ms-unsure 🔍
-1% - +1%
-0.02ms - +0.02ms
preact-main2.97ms - 3.00msunsure 🔍
-1% - +1%
-0.02ms - +0.02ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local29.83ms - 30.70ms-unsure 🔍
-1% - +3%
-0.29ms - +0.81ms
preact-main29.67ms - 30.34msunsure 🔍
-3% - +1%
-0.81ms - +0.29ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local33.96ms - 34.83ms-unsure 🔍
-1% - +3%
-0.42ms - +0.95ms
preact-main33.61ms - 34.65msunsure 🔍
-3% - +1%
-0.95ms - +0.42ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local25.67ms - 26.29ms-unsure 🔍
-1% - +2%
-0.27ms - +0.48ms
preact-main25.67ms - 26.09msunsure 🔍
-2% - +1%
-0.48ms - +0.27ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local25.65ms - 26.54ms-unsure 🔍
-2% - +3%
-0.58ms - +0.76ms
preact-main25.50ms - 26.50msunsure 🔍
-3% - +2%
-0.76ms - +0.58ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local26.99ms - 27.80ms-unsure 🔍
-2% - +2%
-0.53ms - +0.66ms
preact-main26.89ms - 27.76msunsure 🔍
-2% - +2%
-0.66ms - +0.53ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.16ms - 20.54ms-unsure 🔍
-2% - +1%
-0.35ms - +0.20ms
preact-main20.22ms - 20.63msunsure 🔍
-1% - +2%
-0.20ms - +0.35ms		-
text-update
  • Browser: chrome-headless
  • Sample size: 110
  • Built by: CI #4443

  • Commit: 3ddb9a4

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.02ms - 2.15ms-unsure 🔍
-4% - +4%
-0.09ms - +0.09ms
preact-main2.03ms - 2.14msunsure 🔍
-4% - +4%
-0.09ms - +0.09ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.12ms - 1.12ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.12ms - 1.12msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.58ms - 33.78ms-unsure 🔍
-1% - +0%
-0.22ms - +0.11ms
preact-main33.60ms - 33.86msunsure 🔍
-0% - +1%
-0.11ms - +0.22ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.23ms - 1.26ms-unsure 🔍
-2% - +1%
-0.03ms - +0.02ms
preact-main1.23ms - 1.27msunsure 🔍
-1% - +2%
-0.02ms - +0.03ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local31.84ms - 33.45ms-unsure 🔍
-2% - +5%
-0.66ms - +1.56ms
preact-main31.43ms - 32.96msunsure 🔍
-5% - +2%
-1.56ms - +0.66ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.94ms - 2.98ms-unsure 🔍
-1% - +1%
-0.02ms - +0.02ms
preact-main2.94ms - 2.98msunsure 🔍
-1% - +1%
-0.02ms - +0.02ms		-

tachometer-reporter-action v2 for CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

Size Change: 0 B

Total Size: 78.4 kB

ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.12 kB
compat/dist/compat.mjs 4.05 kB
compat/dist/compat.module.js 4.05 kB
compat/dist/compat.umd.js 4.19 kB
debug/dist/debug.js 3.83 kB
debug/dist/debug.mjs 3.83 kB
debug/dist/debug.module.js 3.83 kB
debug/dist/debug.umd.js 3.91 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 274 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.72 kB
dist/preact.min.js 4.73 kB
dist/preact.min.module.js 4.75 kB
dist/preact.min.umd.js 4.75 kB
dist/preact.mjs 4.74 kB
dist/preact.module.js 4.74 kB
dist/preact.umd.js 4.76 kB
hooks/dist/hooks.js 1.54 kB
hooks/dist/hooks.mjs 1.57 kB
hooks/dist/hooks.module.js 1.57 kB
hooks/dist/hooks.umd.js 1.61 kB
jsx-runtime/dist/jsxRuntime.js 978 B
jsx-runtime/dist/jsxRuntime.mjs 952 B
jsx-runtime/dist/jsxRuntime.module.js 952 B
jsx-runtime/dist/jsxRuntime.umd.js 1.05 kB
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 477 B
test-utils/dist/testUtils.module.js 477 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@coveralls
Copy link

coveralls commented Feb 18, 2025 •
edited
Loading

Coverage Status

coverage: 99.609% (+0.7%) from 98.957%
when pulling 2299ad2 on ci/skip-benches-on-release
into e62871c on main.

@rschristian rschristian force-pushed the ci/skip-benches-on-release branch 3 times, most recently from 3ddb9a4 to 2ede918 Compare February 18, 2025 06:37
@rschristian rschristian marked this pull request as ready for review February 18, 2025 06:38
@rschristian rschristian merged commit 3dd0c62 into main Feb 18, 2025
4 checks passed
@rschristian rschristian deleted the ci/skip-benches-on-release branch February 18, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rschristian @coveralls @JoviDeCroock