chore: Simplify compat build script #4677
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on some changes to build output in v11, came across this and figured it was worth addressing separately.
Whilst Microbundle does support multi-entries, it does so incorrectly when combined with the
--cwdflag in that the cwd isn't passed totiny-glob. This hastiny-globresolving from the original cwd (so root of our repo) whichsrc/scheduler.jsfails.src/index.jsworks only as this happens to match core. As such, thesrc/scheduler.jsinput is stripped out & not built as an additional entry.Bundling it separately isn't necessary though, this script has no imports so all microbundle does is minify the ~10loc. None of the other compat entries are bundled either & I think we're pretty happy with how that works?