feat: debug throw on too many rerenders #4349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10k
duration
usedJSHeapSize
filter-list
duration
usedJSHeapSize
hydrate1k
duration
usedJSHeapSize
many-updates
duration
usedJSHeapSize
replace1k
duration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-update
duration
usedJSHeapSize
todo
duration
usedJSHeapSize
update10th1k
duration
usedJSHeapSize
|
|
Size Change: +327 B (0%) Total Size: 61 kB
ℹ️ View Unchanged
|
rschristian
commented
Apr 26, 2024
| if (renderCount >= 25) { | ||
| throw new Error( | ||
| `Too many re-renders. This is limited to prevent an infinite loop ` + | ||
| `which may lock up your browser. The component causing this is: ${getDisplayName( |
There was a problem hiding this comment.
I added the ...which may lock up your browser. bit just to emphasize this isn't something one could safely ignore, especially as we'll only address it in dev (for most users, anyhow. I doubt many are using /debug in prod).
JoviDeCroock
approved these changes
Apr 26, 2024
1 task
Merged
|
Note that this PR appears to throw the rerender error somewhat arbitrarily, causing the app to crash for high render components like the MUI-X Datagrid. Setting preact debug to false in vite.config is a workaround for now. It's possible that the MUI-X DataGrid could use some cleanup to prune renders, but the current performance is acceptable (pretty good actually), the top level component === currentComponent render ++ < 25 may not be robust enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of @andrewiggins' work in #3965, and moves to
/debugas mentioned.