Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add install script inputs #85

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

jeffreys-cat
Copy link
Contributor

We install dependencies with NPM install, Action's installScript npm ci needs a package-lock.json file, otherwise will throw an error. But in some cases, the library use optionalDependencies, package-lock.json is different on different platforms.

For example, vercel's turborepo,I run npm install on my MAC and create a package-lock.json, but only turbo-darwin-arm64 exist in package-lock.json, while pushed it to GitHub and run this Action, because turbo-linux-64 needs on Linux. Then I got an error. I need to use a custom install method npm install --no-package-lock to make it works.

I would like to add an installScript to support custom installation scripts like buildScript.

@nicklmart
Copy link

nicklmart commented Aug 22, 2023

also have a need for this, would like to run npm ci --ignore-scripts instead of npm ci

Is this a suitable solution @developit?

Co-authored-by: Alan Orozco <alanorozco@users.noreply.github.com>
Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers, sorry for the long time without any eyes on this

action.yml Outdated Show resolved Hide resolved
@rschristian rschristian merged commit f135bd3 into preactjs:master Apr 22, 2024
1 check passed
renovate bot added a commit to SAP/ui5-webcomponents-react that referenced this pull request Apr 23, 2024
…5748)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[preactjs/compressed-size-action](https://togithub.com/preactjs/compressed-size-action)
| action | minor | `2.5.0` -> `2.6.0` |

---

### Release Notes

<details>
<summary>preactjs/compressed-size-action
(preactjs/compressed-size-action)</summary>

###
[`v2.6.0`](https://togithub.com/preactjs/compressed-size-action/releases/tag/2.6.0)

[Compare
Source](https://togithub.com/preactjs/compressed-size-action/compare/2.5.0...2.6.0)

#### New Features / Improvements

- \[feature] Add install script inputs by
[@&#8203;jeffreys-cat](https://togithub.com/jeffreys-cat) in
[preactjs/compressed-size-action#85
- feat: Add support for more precise percentage changes by
[@&#8203;mister-ben](https://togithub.com/mister-ben) in
[preactjs/compressed-size-action#97
- Add support for Bun by
[@&#8203;jack-weilage](https://togithub.com/jack-weilage) in
[preactjs/compressed-size-action#104

#### Action Maintenance

- Update action.yml to use node16 by
[@&#8203;estherkim](https://togithub.com/estherkim) in
[preactjs/compressed-size-action#87
- Move to node20, release v3 by
[@&#8203;jonny-puma](https://togithub.com/jonny-puma) in
[preactjs/compressed-size-action#103

#### Repo Maintenance

- Fix typo by [@&#8203;denniskigen](https://togithub.com/denniskigen) in
[preactjs/compressed-size-action#86
- chore: Update Github actions to latest versions by
[@&#8203;mmckenziedev](https://togithub.com/mmckenziedev) in
[preactjs/compressed-size-action#90
- chore: Bump package-lock.json by
[@&#8203;rschristian](https://togithub.com/rschristian) in
[preactjs/compressed-size-action#105

#### New Contributors

- [@&#8203;denniskigen](https://togithub.com/denniskigen) made their
first contribution in
[preactjs/compressed-size-action#86
- [@&#8203;estherkim](https://togithub.com/estherkim) made their first
contribution in
[preactjs/compressed-size-action#87
- [@&#8203;mmckenziedev](https://togithub.com/mmckenziedev) made their
first contribution in
[preactjs/compressed-size-action#90
- [@&#8203;jack-weilage](https://togithub.com/jack-weilage) made their
first contribution in
[preactjs/compressed-size-action#104
- [@&#8203;jonny-puma](https://togithub.com/jonny-puma) made their first
contribution in
[preactjs/compressed-size-action#103
- [@&#8203;mister-ben](https://togithub.com/mister-ben) made their first
contribution in
[preactjs/compressed-size-action#97
- [@&#8203;jeffreys-cat](https://togithub.com/jeffreys-cat) made their
first contribution in
[preactjs/compressed-size-action#85
- [@&#8203;rschristian](https://togithub.com/rschristian) made their
first contribution in
[preactjs/compressed-size-action#105

**Full Changelog**:
preactjs/compressed-size-action@2.5.0...2.6.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/SAP/ui5-webcomponents-react).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants