Address deprecation warning in shutil.rmtree(onerror=...)

[edgarrmondragon]

shutil.rmtree() now accepts a new argument onexc which is an error handler like onerror but which expects an exception instance rather than a (typ, val, tb) triplet. onerror is deprecated and will be removed in Python 3.14. (Contributed by Irit Katriel in gh-102828.)

https://docs.python.org/3.12/whatsnew/3.12.html#shutil

[asottile]

cast should only be used for bugs in the type system

I don't think we need this function any more sooner than the deprecation matters so I'm probably going to decline this anyway

[edgarrmondragon]

cast should only be used for bugs in the type system

I don't think we need this function any more sooner than the deprecation matters so I'm probably going to decline this anyway

No problem. And I prefer avoiding cast but Mypy was complaining that "tuple[type[OSError], OSError, TracebackType] | BaseException" is not indexable.

[asottile]

cast should only be used for bugs in the type system
I don't think we need this function any more sooner than the deprecation matters so I'm probably going to decline this anyway

No problem. And I prefer avoiding cast but Mypy was complaining that "tuple[type[OSError], OSError, TracebackType] | BaseException" is not indexable.

yeah it's not -- the way you've written it is not typesafe

[edgarrmondragon]

FWIW I added a guard to check if the exception is an OSError so that allowed to remove the cast call.