Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Short-circuit check-hooks-apply and check-useless-excludes hooks #2998

Merged
merged 1 commit into from Sep 11, 2023
Merged

Short-circuit check-hooks-apply and check-useless-excludes hooks #2998

merged 1 commit into from Sep 11, 2023

Conversation

mxr
Copy link
Member

@mxr mxr commented Sep 10, 2023

Resolves #2935. Renamed some variables to make mypy happier / improve readability

@mxr mxr marked this pull request as ready for review September 10, 2023 02:23
asottile
asottile approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit f56b75d into main Sep 11, 2023
8 checks passed
@asottile asottile deleted the short-circuit branch September 11, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Short-circuit the check-hooks-apply hook
2 participants
@mxr @asottile