Use os.sched_getaffinity for cpu counts when available #2979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdb8
force-pushed
the
cpu-sched-getaffinity
branch
from
1b44cbd
to
92f905a
Compare
asottile
reviewed
Aug 29, 2023
jdb8
force-pushed
the
cpu-sched-getaffinity
branch
from
0ee30cd
to
4165ed8
Compare
asottile
force-pushed
the
cpu-sched-getaffinity
branch
from
4165ed8
to
ea8244b
Compare
|
pre-commit.ci run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at fixing/improving #2978 for systems that support the
os.sched_getaffinitymethod.When unavailable (i.e. on mac), we fall back to the old behaviour.
I didn't know how much to mess with the existing tests so went with a new fixture to simulate when this is unavailable - I don't have a windows machine to test on so let me know if there's a better way to avoid this change being annoying!
resolves #2978