Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force gem installation into envdir #2905

Merged
merged 2 commits into from Jun 13, 2023

Conversation

jaysoffian
Copy link
Contributor

RubyGems allows OS packagers to specify defaults for --install-dir and --bindir and these take precedence over GEM_HOME. The only way to override the defaults is to explicitly specify the options ourselves when running gem install.

Examples of OSes where this is the case are RedHat 9.2 and Gentoo.

Fixes #2799.

RubyGems allows OS packagers to specify defaults for `--install-dir`
and `--bindir` and these take precedence over `GEM_HOME`. The only way
to override the defaults is to explicitly specify the options ourselves
when running `gem install`.

Examples of OSes where this is the case are RedHat 9.2 and Gentoo.

Fixes pre-commit#2799.
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaysoffian
Copy link
Contributor Author

I'm not sure whether we need to keep specifying --no-user-install and/or GEM_HOME, but I'm not comfortable removing them w/o test coverage across a lot more platforms.

@asottile asottile merged commit e891f86 into pre-commit:main Jun 13, 2023
9 checks passed
@jaysoffian jaysoffian deleted the fix-gem-install branch June 13, 2023 23:39
@jaysoffian jaysoffian restored the fix-gem-install branch June 13, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

No such file or directory: '/github/home/.cache/pre-commit/repo4mrvfeou/rbenv-system/.install_state_v1staging'
2 participants