Use of --dev deprecated for npm

[henryiii]

I'm seeing this warning sometimes (output seems to be hidden unless the install fails):

npm WARN install Usage of the `--dev` option is deprecated. Use `--include=dev` instead.

Which seems to be because of this:

pre-commit/pre_commit/languages/node.py

Line 104 in fe436f1

'npm', 'install', '--dev', '--prod',

The problem with this command was that it installed dependencies recursively, rendering them useless (AFAICT, not a node expert). The developers decided it was only a footgun in npm/npm#5554 (comment) and deprecated in npm/npm#6200.

[asottile]

it's a break either way to change it -- since old npm doesn't support the new flag

the unfortunate thing is that's the command that was recommended by the npm team so...

[henryiii]

What about selecting the flag based on npm version, could that be done here? If so I could look up the version that --include=dev was added.

[asottile]

good luck parsing npm's version and doing anything reasonable with it 😆 . I don't think that's a solution which gives long term stability

[asottile]

did some research on this, and it looks like we can't replace the code we have for this until at least npm 6.x is no longer supported. which would be the EOL of node 14 2023-04-30

[sanmai-NL]

@asottile And here we are.