Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requirements-txt-fixer does not remove duplicated elements #960

Closed
csibe17 opened this issue Sep 6, 2023 · 5 comments · Fixed by #1014
Closed

requirements-txt-fixer does not remove duplicated elements #960

csibe17 opened this issue Sep 6, 2023 · 5 comments · Fixed by #1014

Comments

@csibe17
Copy link

csibe17 commented Sep 6, 2023

In requirements-txt-fixer if there are more than 1 requirement with the same params, the duplicates are not removed.
@asottile
Copy link
Member

asottile commented Sep 6, 2023

can you show an example?

@csibe17
Copy link
Author

csibe17 commented Sep 6, 2023 

dependency1==1.0.0
dependency2==1.0.0
dependency3==1.0.0
dependency1==1.0.0

will end up as

dependency1==1.0.0
dependency1==1.0.0
dependency2==1.0.0
dependency3==1.0.0

@j3962
Copy link

j3962 commented Sep 24, 2023

I am totally new to contributing on open source. If this is indeed an issue. Can I work on it?'

@asottile
Copy link
Member

sure go for it, let me know if you need any help

@j3962
Copy link

j3962 commented Sep 24, 2023 •
edited

Sick! Excited!! Let me get back if I need any help. I might be a bit slow, but I'll get it done for sure! Honestly, I don't understand much from the requirements-txt-fixer, but I'll learn it all. And I am so excited about the possibilities. This is gonna be so much fun! Thank you dude! @asottile can you assign the bug to me?

j3962 pushed a commit to j3962/pre-commit-hooks that referenced this issue Sep 27, 2023
fixing the requirements-txt-fixer pre-commit#960
76da604
j3962 pushed a commit to j3962/pre-commit-hooks that referenced this issue Sep 27, 2023
fixing the requirements-txt-fixer pre-commit#960
1196542
@j3962 j3962 mentioned this issue Sep 27, 2023
Closed
@HeySlava HeySlava mentioned this issue Sep 27, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove duplicated packages vhoulbreque-withings/pre-commit-hooks
3 participants
@csibe17 @asottile @j3962