Remove Python 3.8 constraint from Black pre-commit config #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yea, they added that recently; way after I had authored this file. Thanks for this PR! ^>^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
language_versionoption tells pre-commit to run the hook using that specific version.The current setting of 3.8 messes me up on my M1 because Python 3.8 does not work very well on Apple Silicon.
Generally, it should not be necessary to set this value. Black determines what Python version to target with its
--target-versionoption, which defaults tothe project metadata in pyproject.toml. Further, Black will error if it's run with an incompatible Python version.