Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase icon sizes #554

Merged
merged 2 commits into from Feb 8, 2023
Merged

Conversation

BobDotCom
Copy link
Contributor

@BobDotCom BobDotCom commented Oct 16, 2022

Description

This PR increases the size of some icons in order to improve accessibility, particularly for mobile devices. The larger sizes only consume a slightly larger horizontal width, while the vertical width is mainly unchanged due to padding/margin - which is great, because it only takes up previously empty space. I've included some before/after comparison images below.

Rationale

I've found that on mobile the menu icons are harder to tap than they should be, and compared to honestly most other websites the proportions just look and feel unnatural. I've even had difficulty clicking the icons on desktop sometimes. These new sizes make the site feel more modern and easy to use.

Mobile

Header

  • Before
    Screen Shot 2022-10-15 at 7 52 55 PM
  • After
    Screen Shot 2022-10-15 at 7 53 24 PM

Footer

  • Before
    Screen Shot 2022-10-15 at 7 54 10 PM
  • After
    Screen Shot 2022-10-15 at 7 54 57 PM

Desktop

Header (Wide)

  • Before
    Screen Shot 2022-10-15 at 6 43 04 PM
  • After
    Screen Shot 2022-10-15 at 6 44 14 PM

Header (Narrow)

  • Before
    Screen Shot 2022-10-15 at 7 49 53 PM

  • After
    Screen Shot 2022-10-15 at 7 50 23 PM

Footer

  • Before
    Screen Shot 2022-10-15 at 6 45 57 PM
  • After
    Screen Shot 2022-10-15 at 6 46 26 PM

@BobDotCom
Copy link
Contributor Author

@pradyunsg any feedback on this and #555?

@BobDotCom
Copy link
Contributor Author

BobDotCom commented Feb 8, 2023

@pradyunsg please let me know if you plan on merging this and #555. These PRs include features that I use on my own documentation (https://docs.pycord.dev) and I've made a temporary fork to currently apply the changes, but need to know if I should plan on making a permanent fork of furo or if these improvements will be merged here.

Thanks,
BobDotCom

@pradyunsg pradyunsg merged commit eaafa91 into pradyunsg:main Feb 8, 2023
@pradyunsg
Copy link
Owner

Let's do this. :)

pradyunsg added a commit that referenced this pull request Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants