theme notebook cell borders in dark mode

[jcmgray]

Thanks for the beautiful theme!

I'd be keen to use this theme with either nbsphinx or myst_nb to render notebook docs - it already looks great in light mode. In dark mode the cells do have a pronounced white border that is a bit jarring however:

and here's maybe a desired look after tweaking some parameters (border and background color) in inspect element...

just wondering if this kind of special case element theming might make it into the theme?

[pradyunsg]

I'm not familiar with myst-nb or nbsphinx, but special-casing extensions is welcome -- there's already a few of those in https://github.com/pradyunsg/furo/tree/main/src/furo/assets/styles/extensions

[chrisjsewell]

For myst-nb, let me know if this requires any upstream improvements 😄 the CSS is pretty simple: https://github.com/executablebooks/MyST-NB/blob/master/myst_nb/static/mystnb.css

[pradyunsg]

A PR would be welcome for this.

The way I'm imagining this can be achieved is by adding a new file to https://github.com/pradyunsg/furo/tree/main/src/furo/assets/styles/extensions, setting the relevant CSS variables needed based on https://github.com/executablebooks/MyST-NB/blob/master/myst_nb/static/mystnb.css in html (instead of :root) based off of Furo's own internal CSS variables (similar to how sphinx-inline-tabs is supported).