Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shift-delete not working at song select #24878

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

peppy
Copy link
Member

@peppy peppy commented Sep 21, 2023

Sorry, something went wrong.

@peppy peppy added the next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! label Sep 21, 2023
@peppy peppy requested a review from bdach September 21, 2023 16:26
@frenzibyte frenzibyte self-requested a review September 21, 2023 17:11
@frenzibyte
Copy link
Member

Was weirded out by the change in this PR at first glance, but it looks like a consensus of this was reached over at ppy/osu-framework#5997. Have added a explanatory comment as it's not quite obvious why clipboard is suddenly disabled at first glance.

frenzibyte
frenzibyte previously approved these changes Sep 21, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@bdach bdach enabled auto-merge September 21, 2023 18:07
@bdach bdach disabled auto-merge September 21, 2023 18:48
@bdach bdach merged commit 561f664 into ppy:master Sep 21, 2023
@peppy peppy deleted the fix-song-select-shift-delete branch September 26, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:song-select next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't shift-delete to delete beatmap in song select anymore
3 participants