Added support for skipping request execution through script #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedkribhu
force-pushed
the
feat/skip-request-remove-listener
branch
from
d49315f
to
a9bb7c1
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #1354 +/- ##
===========================================
+ Coverage 78.59% 78.73% +0.14%
===========================================
Files 45 45
Lines 3298 3316 +18
Branches 943 947 +4
===========================================
+ Hits 2592 2611 +19
+ Misses 706 705 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Test failures are expected until sandbox version bump. |
appurva21
requested changes
Oct 31, 2023
appurva21
reviewed
Oct 31, 2023
| originalContextOnHandler.call(context, eventName, function () { | ||
| const cursor = arguments && arguments[0]; | ||
|
|
||
| if (cursor && cursor.execution && isExecutionSkipped(cursor.execution)) { return; } |
There was a problem hiding this comment.
@codenirvana FYI This approach introduces a risk for any new event introduced in sandbox, that does not emit cursor as its first argument.
codenirvana
changed the title
codenirvana
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for
pm.execution.skipRequest()