Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for ASAP auth #1340

Merged
merged 4 commits into from Oct 16, 2023
Merged

Added support for ASAP auth #1340

merged 4 commits into from Oct 16, 2023

Conversation

abhijeetborole
Copy link
Member

@abhijeetborole abhijeetborole commented Sep 27, 2023

This adds functionality to send requests with Atlassian's S2S Authentication Protocol, or ASAP auth
https://s2sauth.bitbucket.io/spec/

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023

Codecov Report

Merging #1340 (356f0bb) into develop (95edf42) will decrease coverage by 35.93%.
The diff coverage is 79.22%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff              @@
##           develop    #1340       +/-   ##
============================================
- Coverage    78.33%   42.41%   -35.93%     
============================================
  Files           44       45        +1     
  Lines         3217     3294       +77     
  Branches       923      938       +15     
============================================
- Hits          2520     1397     -1123     
- Misses         697     1897     +1200     
Flag Coverage Δ
integration ?
legacy ?
unit 42.41% <79.22%> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/authorizer/index.js 100.00% <ø> (ø)
lib/authorizer/asap.js 79.22% <79.22%> (ø)

... and 31 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@codenirvana codenirvana changed the title add asap auth Added support for ASAP auth Oct 11, 2023
@codenirvana codenirvana merged commit 932ab9a into develop Oct 16, 2023
9 checks passed
@codenirvana codenirvana deleted the feature/add-asap-auth branch October 16, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants