Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key packages in Script #1356

Merged
merged 3 commits into from Feb 28, 2024
Merged

Add key packages in Script #1356

merged 3 commits into from Feb 28, 2024

Conversation

coditva
Copy link
Member

@coditva coditva commented Feb 22, 2024

Picked changes from #1352 by @aditya-baradwaj


We are adding a key packages inside Script.

  • packages is an object, with name of the package as the key, and value being an object that contains the id of the package.
  • This key is optional. If this key is not already present, it will NOT be added with a default value.
"script": {
    "id": "51f1d8c7-6006-43e8-90f6-846cc8144d7f",
    "exec": [
        "console.log('x');"
    ],
    "type": "text/javascript",
    "packages": {
        "package1": {
            "id": "9e85cce9-389d-43f4-8fa1-4c4340585521"
        },
        "package2": {
            "id": "a09d471f-ec97-47fa-85fe-e59d9098dad2"
        }
    }
}

@coditva coditva force-pushed the feat/packages-in-scripts branch 2 times, most recently from b9a4fff to 6b55bcf Compare February 22, 2024 06:29
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a175ec3) to head (81c4174).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #1356   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         2176      2177    +1     
  Branches       660       660           
=========================================
+ Hits          2176      2177    +1     
Flag Coverage Δ
unit 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coditva coditva marked this pull request as ready for review February 26, 2024 11:41
@codenirvana codenirvana merged commit 28b67b1 into develop Feb 28, 2024
8 checks passed
@codenirvana codenirvana deleted the feat/packages-in-scripts branch February 28, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants