-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add some platform info to events #198
Merged
Merged
+163
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR adds platform information to events captured by the PostHog Python client, enhancing error tracking capabilities with environmental context.
- Added
get_os_info()
function in/posthog/client.py
that detects and standardizes OS name and version across Windows, macOS, Linux, FreeBSD, and other platforms - Added
system_context()
function that returns Python runtime, Python version, OS name, and OS version information - Modified the
capture
method to include system context in event properties - Implemented platform-specific detection logic using
sys.platform
andplatform
module with fallbacks for different Python versions - Added special handling for Linux distributions to extract version information from either deprecated
platform.linux_distribution()
or the newerdistro
module
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
daibhin
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this isn't very useful in product analytics but would be super useful in error tracking