improve sourcemap performance #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Sep 16, 2023
lib/map-generator.js
Outdated
Comment on lines
21
to
23
| this.memoizedFileURLs = new Map(); | ||
| this.memoizedPaths = new Map(); | ||
| this.memoizedURLs = new Map(); |
There was a problem hiding this comment.
Specific operations were done very frequently and were slow.
As far as I can tell these can be memoized.
This dramatically improves performance of sourcemap generation.
I don't have a strong opinion on naming or best practices here.
Please advice if there is a more idiomatic way to memoize these values within PostCSS.
|
Can you show the benchmark results (before/after) on you machine? |
|
On my machine (M2 air) : |
ai
reviewed
Sep 16, 2023
ai
reviewed
Sep 16, 2023
lib/map-generator.js
Outdated
| file = relative(from, file) | ||
| return file | ||
| let path = relative(from, file) | ||
| this.memoizedPaths.set(file, path); |
Co-authored-by: Andrey Sitnik <andrey@sitnik.ru>
|
Looks amazing. I will accept it tomorrow. Don’t want to accept and release before going to bed :D. |
romainmenke
deleted the
improve-sourcemap-performance--philosophical-spiny-dogfish-3eb029c1c8
branch
|
Thanks. Released in 8.4.30. |
|
Awesome! thank you 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related change to PostCSS benchmarks : postcss/benchmark#32