Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DOM): iOS safari pinch zooming fix #1843

Merged
merged 2 commits into from
Aug 7, 2022

Conversation

ptu14
Copy link
Contributor

@ptu14 ptu14 commented Aug 6, 2022

This is an amendment from @floating-ui adapted to @popperjs and flow

fix: #1121
original fix: #1576
also discussion: #1839

@rollingversions
Copy link

rollingversions bot commented Aug 6, 2022

Change Log for @popperjs/core (2.11.5 → 2.11.6)

Bug Fixes

Edit changelog

@ptu14 ptu14 force-pushed the fix/mobile-safari-pinch-zoom branch 2 times, most recently from 5472245 to 636433b Compare August 6, 2022 20:35
@ptu14 ptu14 force-pushed the fix/mobile-safari-pinch-zoom branch from 636433b to aa63fe1 Compare August 6, 2022 20:59
Copy link
Collaborator

@atomiks atomiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run prettier on these files? formatting looks a bit off in some areas

Also, can you reuse the user agent function for the firefox user agent check?

@ptu14
Copy link
Contributor Author

ptu14 commented Aug 7, 2022

done, check latest commit

@atomiks
Copy link
Collaborator

atomiks commented Aug 7, 2022

thx 👍

@atomiks atomiks merged commit 9936df3 into floating-ui:v2.x Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants