Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude self as scrollParent #1147

Merged
merged 1 commit into from
Jul 3, 2020

Conversation

atomiks
Copy link
Collaborator

@atomiks atomiks commented Jul 3, 2020

Closes #1146

The element (reference) itself was considered a clippingParent due to overflow property, but it should be excluded.

@rollingversions
Copy link

rollingversions bot commented Jul 3, 2020

Change Log for @popperjs/core (2.4.3 → 2.4.4)

Bug Fixes

  • Exclude reference element from scroll parents list

Edit changelog

@FezVrasta FezVrasta merged commit e3c9027 into floating-ui:master Jul 3, 2020
@atomiks atomiks deleted the fix/reference-scrollParent branch July 3, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with data-popper-escaped and overflow: hidden button reference
2 participants