Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

北极星旁路功能插件设计——支持 Local Plugin 以及 Remote Plugin 模式 #757

Closed
chuntaojun opened this issue Oct 18, 2022 · 4 comments · May be fixed by #1139
Closed

北极星旁路功能插件设计——支持 Local Plugin 以及 Remote Plugin 模式 #757

chuntaojun opened this issue Oct 18, 2022 · 4 comments · May be fixed by #1139
Assignees
Labels
good advanced issue suitable for basis of source code issue-shoot issue-shoot activity need discuss Need to discuss plugin polaris-server plugin

Comments

@chuntaojun
Copy link
Member

  北极星插件的开发规范及开发指南
  • 北极星当前的插件架构设计
    • 分为核心模块插件以及旁路功能插件
    • 与服务端同进程运行,插件定义基于 go 的 interface
    • 插件的注册依赖于 go 的 init 机制
    • 每个插件的名称全局唯一
    • 每个插件都必须是一个单例的,需要插件自行保证并发场景下的安全性
    • 插件需要和服务端一同编译
  • 存在的问题
    • 第三方插件代码的稳定性需要贡献者保证,插件更新不及时可能会影响北极星主体程序的稳定
    • 主仓库代码维护的工作量变大
    • 插件无法自己控制版本更新
    • 用户用不上这些插件,但是正式 release 版本会连带这些第三方插件一并构建编译
  • 后期计划的优化措施

Originally posted by @chuntaojun in #753 (comment)

@chuntaojun chuntaojun added need discuss Need to discuss plugin polaris-server plugin labels Oct 18, 2022
@chuntaojun chuntaojun added this to the v1.13.0 milestone Oct 18, 2022
@chuntaojun chuntaojun added the good advanced issue suitable for basis of source code label Oct 21, 2022
@JellyZero
Copy link

可以参考 go-micro 机制,

@chuntaojun
Copy link
Member Author

go-micro

目前是差不多的,我们需要针对旁路功能插件设计 local 和 remote

@chuntaojun
Copy link
Member Author

  • 核心插件建议同进程
  • 旁路功能插件可以考虑看看 hashicorp/go-plugin,即可以考虑跨进程(欢迎贡献)

@chuntaojun chuntaojun added the issue-shoot issue-shoot activity label Oct 28, 2022
@chuntaojun chuntaojun changed the title 北极星插件的开发规范及开发指南 北极星旁路功能插件设计——支持 Local Plugin 以及 Remote Plugin 模式 Oct 28, 2022
@edocevol
Copy link
Contributor

edocevol commented Nov 1, 2022

WIP~

@chuntaojun chuntaojun modified the milestones: v1.13.0, v1.14.0 Nov 24, 2022
@chuntaojun chuntaojun modified the milestones: v1.14.0, v1.15.0 Feb 10, 2023
@chuntaojun chuntaojun modified the milestones: v1.15.0, v1.16.0 Mar 6, 2023
@chuntaojun chuntaojun modified the milestones: v1.16.0, v1.17.0 Mar 31, 2023
@chuntaojun chuntaojun removed this from the v1.17.0 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good advanced issue suitable for basis of source code issue-shoot issue-shoot activity need discuss Need to discuss plugin polaris-server plugin
Projects
None yet
3 participants