fix: Fix DuplicateError when selecting columns after join_where or cross join + filter
#20865
+47
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
nameexhaustion
changed the title
join_where or cross join + filterjoin_where or cross join + filter
nameexhaustion
commented
Jan 23, 2025
| @@ -197,10 +197,6 @@ impl ExprIR { | |||
| self.output_name = OutputName::Alias(name) | |||
| } | |||
|
|
|||
| pub(crate) fn set_columnlhs(&mut self, name: PlSmallStr) { | |||
| self.output_name = OutputName::ColumnLhs(name) | |||
| } | |||
There was a problem hiding this comment.
This is a very evil function 😭
There was a problem hiding this comment.
Wow, yes. The expression remain unchanged. :S
nameexhaustion
changed the title
join_where or cross join + filterjoin_where or cross join + filter
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
ritchie46
approved these changes
Jan 23, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20865 +/- ##
==========================================
- Coverage 79.64% 79.64% -0.01%
==========================================
Files 1571 1571
Lines 223165 223186 +21
Branches 2546 2554 +8
==========================================
+ Hits 177737 177751 +14
- Misses 44844 44850 +6
- Partials 584 585 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Update - what this PR does is not correct, it is superceded by #21067
Fixes #20831
join_wherefails with DuplicateError #20831We have had this issue for queries in the form
.join(.., how='cross').filter(..).select(..)for quite a while (since version 1.8.2).