Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Implement arg_sort for Null series #20135

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

coastalwhite
Copy link
Collaborator

@coastalwhite coastalwhite commented Dec 3, 2024

Fixes #17007, #14509.

Fixes pola-rs#17007.
@coastalwhite coastalwhite changed the title fix: Implement arg_sort for Null series fix: Implement arg_sort for Null series Dec 3, 2024
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 3, 2024
@s-banach
Copy link
Contributor

s-banach commented Dec 3, 2024

Closes #14509?

@coastalwhite

This comment was marked as resolved.

@coastalwhite coastalwhite merged commit 9b91418 into pola-rs:main Dec 3, 2024
23 checks passed
@coastalwhite coastalwhite deleted the fix/sort-null-panic branch December 3, 2024 15:48
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.53%. Comparing base (d86e44b) to head (33208c9).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...tes/polars-core/src/series/implementations/null.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20135      +/-   ##
==========================================
+ Coverage   79.52%   79.53%   +0.01%     
==========================================
  Files        1563     1564       +1     
  Lines      217186   217206      +20     
  Branches     2465     2465              
==========================================
+ Hits       172715   172757      +42     
+ Misses      43910    43888      -22     
  Partials      561      561              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when sorting DataFrame by Null column
2 participants