Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't access out-of-bounds for null indices in bitmap gather #14932

Merged
merged 3 commits into from
Mar 9, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Mar 8, 2024

Fixes #14927.

Verified

This commit was signed with the committer’s verified signature.
nunogois Nuno Góis
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Mar 8, 2024
@ritchie46 ritchie46 enabled auto-merge (squash) March 8, 2024 16:16
@ritchie46 ritchie46 changed the title fix: don't access out-of-bounds for null indices in bitmap gather fix: Don't access out-of-bounds for null indices in bitmap gather Mar 8, 2024
@ritchie46 ritchie46 disabled auto-merge March 8, 2024 16:27
@ritchie46
Copy link
Member

Can you add the repro as test?

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 47.61905% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 81.01%. Comparing base (d9dead6) to head (a4c95f8).
Report is 6 commits behind head on main.

Files Patch % Lines
crates/polars-arrow/src/compute/take/bitmap.rs 47.36% 10 Missing ⚠️
crates/polars-arrow/src/compute/take/boolean.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14932      +/-   ##
==========================================
- Coverage   81.01%   81.01%   -0.01%     
==========================================
  Files        1332     1332              
  Lines      172870   172882      +12     
  Branches     2458     2458              
==========================================
+ Hits       140054   140063       +9     
- Misses      32348    32351       +3     
  Partials      468      468              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit dc95ac8 into pola-rs:main Mar 9, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation Fault on Accessing Field of Struct in List when null
2 participants