Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix hashing specialization #14754

Merged
merged 2 commits into from
Feb 29, 2024
Merged

fix: fix hashing specialization #14754

merged 2 commits into from
Feb 29, 2024

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Feb 29, 2024

fixes #14749

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Feb 29, 2024
@nameexhaustion
Copy link
Collaborator

Some other places (all?), (e.g. numeric_vec_hash_combine) that previously hashed &T were also changed by #14648 to hash T instead of &T, but I think those are ok since they aren't mixing between hashes of T and &T. group_by_threaded_slice/iter were problematic because they used insert_with_hasher that allowed us to insert a hashing function that did not hash the same way as the initial key.

@ritchie46
Copy link
Member Author

Some other places (all?)

I believe not, but please double check. The more eyes over this the better.

@ritchie46 ritchie46 merged commit 8d0cdc2 into main Feb 29, 2024
23 checks passed
@ritchie46 ritchie46 deleted the hash branch February 29, 2024 04:42
@nameexhaustion
Copy link
Collaborator

I'm now actually inclined to believe hash_one(x) should have been equivalent to hash_one(&x) - opened an issue with aHash at tkaitchuck/aHash#214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-deterministic and incomplete group_by in 0.20.11
2 participants