Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix bug where alias was ignored in COUNT(*) optimization #14738

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

c-peters
Copy link
Collaborator

The alias was ignored in the optimization which lead to schema mismatches between optimized and non-optimized.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 98.63014% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.06%. Comparing base (d4ee7a7) to head (0f06cd6).
Report is 1 commits behind head on main.

Files Patch % Lines
...lars-plan/src/logical_plan/optimizer/count_star.rs 98.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14738   +/-   ##
=======================================
  Coverage   81.06%   81.06%           
=======================================
  Files        1322     1322           
  Lines      171364   171395   +31     
  Branches     2461     2461           
=======================================
+ Hits       138910   138944   +34     
+ Misses      31983    31981    -2     
+ Partials      471      470    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 6bb937d into pola-rs:main Feb 28, 2024
19 checks passed
@c-peters c-peters added the accepted Ready for implementation label Mar 4, 2024
@c-peters c-peters self-assigned this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants