Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow non-strict construction / initialization of Enum columns #14728

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

c-peters
Copy link
Collaborator

fix #14725

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Feb 27, 2024
@c-peters
Copy link
Collaborator Author

@stinodego , could you have a look at this one? Especially the _construction.py , I am not entirely sure if setting strict=strict would only need to be applied for Enums or can be left for all other logicals

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.06%. Comparing base (9bb0cf0) to head (68534cc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14728      +/-   ##
==========================================
- Coverage   81.06%   81.06%   -0.01%     
==========================================
  Files        1322     1322              
  Lines      171360   171355       -5     
  Branches     2461     2461              
==========================================
- Hits       138909   138904       -5     
  Misses      31980    31980              
  Partials      471      471              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego
Copy link
Member

stinodego commented Feb 29, 2024

@stinodego , could you have a look at this one? Especially the _construction.py , I am not entirely sure if setting strict=strict would only need to be applied for Enums or can be left for all other logicals

I think it's fine like this.

@ritchie46 ritchie46 merged commit 4967150 into pola-rs:main Feb 29, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow converting unknown values to null in pl.Enum
3 participants