Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: don't reassign chunks back to df owner #14633

Merged
merged 1 commit into from
Feb 22, 2024
Merged

perf: don't reassign chunks back to df owner #14633

merged 1 commit into from
Feb 22, 2024

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Feb 22, 2024

This creates chunks for the writer. Which may slow down future operations.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@3b065f3). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14633   +/-   ##
=======================================
  Coverage        ?   80.77%           
=======================================
  Files           ?     1326           
  Lines           ?   173086           
  Branches        ?     2453           
=======================================
  Hits            ?   139803           
  Misses          ?    32810           
  Partials        ?      473           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 21d4326 into main Feb 22, 2024
20 checks passed
@ritchie46 ritchie46 deleted the write branch February 22, 2024 03:16
@c-peters c-peters added the accepted Ready for implementation label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants