Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rust!): Mark DataFrame::new_no_checks and DataFrame::new_no_length_checks unsafe #14443

Merged
merged 8 commits into from
Feb 18, 2024
Merged

feat(rust!): Mark DataFrame::new_no_checks and DataFrame::new_no_length_checks unsafe #14443

merged 8 commits into from
Feb 18, 2024
+165 −160

Conversation

stinodego
Copy link
Contributor

@stinodego stinodego commented Feb 12, 2024 •
edited
Loading

Ref #14431 (comment)

Changes

  • Mark the mentioned methods unsafe
  • Update references to use unsafe blocks
  • Use DataFrame::empty and Series::into_frame() where possible, rather than an unsafe call to DataFrame::new_no_checks

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Feb 12, 2024
@stinodego stinodego marked this pull request as ready for review February 12, 2024 20:16
@ritchie46
Copy link
Member

Yes, that one should be marked unsafe as well.

@stinodego stinodego changed the title refactor(rust): Mark DataFrame::new_no_length_checks unsafe refactor(rust!): Mark DataFrame::new_no_length_checks unsafe Feb 14, 2024
@github-actions github-actions bot added the breaking rust Change that breaks backwards compatibility for the Rust crate label Feb 14, 2024
@stinodego stinodego changed the title refactor(rust!): Mark DataFrame::new_no_length_checks unsafe refactor(rust!): Mark DataFrame::new_no_checks and DataFrame::new_no_length_checks unsafe Feb 14, 2024
@stinodego
Mark new_no_length_checks unsafe
d06acd2
@stinodego
Fix panic message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
b9c9aff
@stinodego
Formatting
223c8fc
@stinodego
Add safety comment

Verified

This commit was signed with the committer’s verified signature.
codebytere Shelley Vohr
GPG key ID: F13993A75599653C
Verified
Learn about vigilant mode
dd5e078
@stinodego
Mark unsafe

Verified

This commit was signed with the committer’s verified signature.
BethGriggs Bethany Griggs
GPG key ID: D7062848A1AB005C
Verified
Learn about vigilant mode
191f916
@stinodego
Mark unsafe

Verified

This commit was signed with the committer’s verified signature.
BethGriggs Bethany Griggs
GPG key ID: D7062848A1AB005C
Verified
Learn about vigilant mode
8d5c2ed
@stinodego
Use empty where appropriate

Verified

This commit was signed with the committer’s verified signature.
BethGriggs Bethany Griggs
GPG key ID: D7062848A1AB005C
Verified
Learn about vigilant mode
bca6201
@stinodego
Use into_frame where appropriate
52434da
@stinodego stinodego marked this pull request as draft February 14, 2024 09:45
@stinodego stinodego marked this pull request as ready for review February 14, 2024 09:48
@stinodego stinodego changed the title refactor(rust!): Mark DataFrame::new_no_checks and DataFrame::new_no_length_checks unsafe feat(rust!): Mark DataFrame::new_no_checks and DataFrame::new_no_length_checks unsafe Feb 14, 2024
@stinodego stinodego removed the internal An internal refactor or improvement label Feb 14, 2024
@github-actions github-actions bot added the enhancement New feature or an improvement of an existing feature label Feb 14, 2024
@stinodego stinodego merged commit 76def30 into main Feb 18, 2024
@stinodego stinodego deleted the df-unsafe branch February 18, 2024 21:04
@etiennebacher etiennebacher mentioned this pull request Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46

@orlp orlp

@c-peters c-peters

@alexander-beedie alexander-beedie

@MarcoGorelli MarcoGorelli

Assignees
No one assigned
Labels
breaking rust Change that breaks backwards compatibility for the Rust crate enhancement New feature or an improvement of an existing feature rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stinodego @ritchie46