perf: improve iteration performance #14126
Merged
+126
−114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a long standing annoyance. The
IntoIterator
trait doesn't allow for enough generics so we had to return aBox<dyn Iterator>
. Which meant a dynamic function call on every iteration and the iterator is completely opaque to the compiler.This adds an
iter
metod directly onChunkedArray<T>
for allT: PolarsDataType
. This should be preferred overinto_iter
at all cost.Note that it still is a nested iterator (as we iterate over different chunks). So if you can please unpack your nestedness during iteration with: