Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: elide unneeded work in window? #14108

Merged
merged 1 commit into from
Jan 30, 2024
Merged

perf: elide unneeded work in window? #14108

merged 1 commit into from
Jan 30, 2024

Conversation

ritchie46
Copy link
Member

Very surprised the compiler didn't warn about this. Wonder if this was in the final binary, but it was completely unneeded work.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Jan 30, 2024
@ritchie46 ritchie46 merged commit a648478 into main Jan 30, 2024
@ritchie46 ritchie46 deleted the window branch January 30, 2024 16:25
@c-peters c-peters added the accepted Ready for implementation label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants